-
Notifications
You must be signed in to change notification settings - Fork 29
DOCSP-44008: read/write sinatra quickstart #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-44008: read/write sinatra quickstart #50
Conversation
✅ Deploy Preview for docs-mongoid ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some non-blocking suggestions
|
||
In the ``app.rb`` file, create a model called ``Restaurant`` | ||
to represent data from the sample ``restaurants`` collection in | ||
your MongoDB database: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: specify the database
your MongoDB database: | |
the ``sample_restaurants`` database: |
To display your data in a specified way by using HTML, you can | ||
create a **view**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: since this is a procedure step, I'd change the verb tense:
To display your data in a specified way by using HTML, you can | |
create a **view**. | |
Create a **view** to display your data in a specified way by using HTML. |
use the ``to_json()`` method to display your results in JSON | ||
format. | ||
|
||
Replace the ``list_restaurants`` route with the following code to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: clarify which file you're editing
Replace the ``list_restaurants`` route with the following code to | |
Replace the ``list_restaurants`` route in the ``app.rb`` file with the following code to |
.. step:: Post a request to create a restaurant entry | ||
|
||
Send a ``Restaurant`` instance to the ``add_restaurant`` endpoint | ||
by running the following command in your shell: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: Clarify where you should run the command
by running the following command in your shell: | |
from the application root directory: |
|
||
.. TODO Learn more about {+odm+} features from the following resources: | ||
|
||
.. - :ref:`mongoid-fundamentals-connection`: learn how to configure your MongoDB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: capitalize the first word after these colons
.. - :ref:`mongoid-fundamentals-connection`: learn how to configure your MongoDB | |
.. - :ref:`mongoid-fundamentals-connection`: Learn how to configure your MongoDB |
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44008
Staging:
Self-Review Checklist